Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit sticky app bar & header #583

Merged
merged 4 commits into from
Sep 27, 2021
Merged

Edit sticky app bar & header #583

merged 4 commits into from
Sep 27, 2021

Conversation

0shar0
Copy link
Collaborator

@0shar0 0shar0 commented Sep 23, 2021

No description provided.

@0shar0 0shar0 self-assigned this Sep 23, 2021
sarmong
sarmong reviewed Sep 24, 2021
View reviewed changes
src/models/headerVisibility/selecor.ts Outdated
import { RootStateType } from '../rootReducer';
import { IVisibilityState } from './types';

export const selectHeaderVisibility = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the filename

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

sarmong
sarmong reviewed Sep 24, 2021
View reviewed changes
src/models/headerVisibility/reducer.ts Outdated
makeHeaderVisible: (state) => {
state.visibility = true;
},
makeHeaderUnVisible: (state) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invisible

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@0shar0 0shar0 requested a review from daniloflek September 24, 2021 11:48
@niksonax niksonax self-requested a review September 27, 2021 10:29
@0shar0 0shar0 merged commit 8d4e540 into develop Sep 27, 2021
@0shar0 0shar0 deleted the edit_sticky_appBar_&_header branch September 27, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niksonax niksonax niksonax approved these changes

@sarmong sarmong sarmong approved these changes

@sarhan-azizov sarhan-azizov Awaiting requested review from sarhan-azizov sarhan-azizov is a code owner

@daniloflek daniloflek Awaiting requested review from daniloflek

Assignees

@0shar0 0shar0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0shar0 @sarmong @niksonax